Fix #6608 normalized job_driver's agent life cycle code #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robnagler
commented
Dec 21, 2023
robnagler
commented
- Changed some conditionals to assertions to simplify code
- Locking around start and end of the agent life (_agent_life_change_lock)
- Ops are bound to driver in prepare_send, was too early in agent_start
- Fix job_driver._agent_start_delay is global but should be local #6613 _agent_start_delay is local to op
- Fix Improve logging and failure cases related to sirepo.status #6572 added more logging, fixed some messages, and normalized others
- Cleaned up some naming (opId > op_id when not in msg)
- Cascade exceptions into op.internal_error for better logging
- Improved error handling/logging in sirepo.status
- Changed some conditionals to assertions to simplify code - Locking around start and end of the agent life (_agent_life_change_lock) - Ops are bound to driver in prepare_send, was too early in agent_start - Fix #6613 _agent_start_delay is local to op - Fix #6572 added more logging, fixed some messages, and normalized others - Cleaned up some naming (opId > op_id when not in msg) - Cascade exceptions into op.internal_error for better logging - Improved error handling/logging in sirepo.status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.