Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak in r_asm_mdisassemble #7163

Merged
merged 1 commit into from
Mar 28, 2017
Merged

fix memory leak in r_asm_mdisassemble #7163

merged 1 commit into from
Mar 28, 2017

Conversation

tilsche
Copy link
Contributor

@tilsche tilsche commented Mar 27, 2017

buf_asm was redundantly allocated with malloc, then overwritten from a strbuf.

@radare
Copy link
Collaborator

radare commented Mar 28, 2017

a null deref will be spotted before the leak actually, mind to update the pr?

@tilsche
Copy link
Contributor Author

tilsche commented Mar 28, 2017

Changed tabs and commit message. Was that what you meant?

@radare radare merged commit 1a72b58 into radareorg:master Mar 28, 2017
@tilsche tilsche deleted the fix_mdisassemble_leak branch March 29, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tilsche @radare