Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename try_walkthrough_jmptbl -> r_anal_jmptbl_try_walkthrough #23913

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jukuisma
Copy link
Contributor

  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some lines in the book (optional)

Description

Missed when grepping for R2_600 renaming stuff.

@jukuisma jukuisma force-pushed the r2600-rename-walk-jmptbl branch from 94d0bd1 to f13c5e2 Compare January 20, 2025 15:36
@trufae
Copy link
Collaborator

trufae commented Jan 20, 2025

What about something shorter like r_anal_jmptbl_trywalk()? Or maybe we can find a better name? Any proposal?

@jukuisma
Copy link
Contributor Author

What about something shorter like r_anal_jmptbl_trywalk()? Or maybe we can find a better name? Any proposal?

Even shorter R_API bool r_anal_jmptbl_walk seems logical as well.

@trufae
Copy link
Collaborator

trufae commented Jan 21, 2025

Yeah lets remove the try . Your suggestion lgtm

@jukuisma jukuisma force-pushed the r2600-rename-walk-jmptbl branch from f13c5e2 to 6351829 Compare January 21, 2025 16:43
@jukuisma
Copy link
Contributor Author

Rebased && renamed: 6351829

@trufae trufae merged commit a14cb18 into radareorg:master Jan 21, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants