WIP: Initial support for UF2 file format #io #23117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviciano
changed the title
trufae
reviewed
Jul 10, 2024
|
You cant use anal or core from io. Use the coreb struct or so _r_core_cmdf, referenced from: |
trufae
requested changes
Jul 12, 2024
libr/io/p/io_uf2.c
Outdated
| } | ||
|
|
||
| static bool uf2_read(RIO *io, RBuffer *rbuf, char *buf) { | ||
|
|
libr/io/p/io_uf2.c
Outdated
| } | ||
|
|
||
| comment = r_str_newf ("uf2 block #%02d (%d bytes @ 0x%08x)\n", block.blockNo, block.payloadSize, block.targetAddr); | ||
| r_meta_set_string (core->anal, R_META_TYPE_COMMENT, block.targetAddr, comment); |
There was a problem hiding this comment.
use io->coreb.cmdf (core, comment);
There was a problem hiding this comment.
where comment must start with "CC ... aka contain the command that adds a comment
libr/io/p/io_uf2.c
Outdated
| return -1; | ||
| } | ||
|
|
||
| static void process_family_id(RCore *core, ut32 family_id) { |
There was a problem hiding this comment.
Suggested change
| static void process_family_id(RCore *core, ut32 family_id) { | |
| static void process_family_id(RIO *io, ut32 family_id) { |
pass io, this way the function have also access to the RCoreBind struct and call io->coreb.cmdf(io->coreb.core, ...)
trufae
requested changes
Jul 13, 2024
trufae
reviewed
Jul 13, 2024
trufae
reviewed
Jul 13, 2024
trufae
reviewed
Jul 13, 2024
trufae
reviewed
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial uf2:// io plugin.
Many functionalities still need to be implemented (write, checksum validation, file container, ...)