Remove duplicated function signature entries #23098
Conversation
| @@ -958,14 +958,8 @@ R_API int r_sign_all_functions(RAnal *a, bool merge) { | |||
| RSignItem *it = NULL; | |||
| if (merge || !name_exists (a->sdb_zigns, realname, sp)) { | |||
| it = item_from_func (a, fcn, realname); | |||
| } else { | |||
There was a problem hiding this comment.
the fix looks good and i think thats a good default behaviour, but maybe we should allow users to have the same signature twice too. maybe we can have the zign.dups config variable for this, and maybe we need to break the abi to add such option inside RAnalOptions. but i think is better to have this feature as an option and disabled by default rather than removing the code. what do you think?
|
You can use the RCoreBind field from RAnal.coreb for now to achieve this, put the ConfigGet call outside the loop to avoid perf issues. add a comment for R2_600 to add the field in RAnalOptions this way we dont break the abi. the option will be disabled by default . add it in core/cconfig.c |
|
Allright, I will try my best to implement it. Thanks for all the tips 😁 |
|
Looks perfect now :) thank you! |
Description
Probably solves the issue #22901. I removed the code that creates new signatures from the same functions.