Fix a couple of debugger warnings for linux and macos

radareorg · Jun 13, 2024 · 7479389 · 7479389
1 parent 1d6210b
commit 7479389
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/libr/bp/bp.c b/libr/bp/bp.c
@@ -162,8 +162,8 @@ static void unlinkBreakpoint(RBreakpoint *bp, RBreakpointItem *b) {
 }
 
 /* TODO: detect overlapping of breakpoints */
-static RBreakpointItem *r_bp_add(RBreakpoint *bp, const ut8 *obytes, ut64 addr, int size, int hw, int perm) {
-	R_RETURN_VAL_IF_FAIL (bp && obytes, NULL);
+static RBreakpointItem *r_bp_add(RBreakpoint *bp, R_NULLABLE const ut8 *obytes, ut64 addr, int size, int hw, int perm) {
+	R_RETURN_VAL_IF_FAIL (bp, NULL);
 	if (addr == UT64_MAX || size < 1) {
 		return NULL;
 	}

diff --git a/libr/debug/debug.c b/libr/debug/debug.c
@@ -283,7 +283,7 @@ R_API RBreakpointItem *r_debug_bp_add(RDebug *dbg, ut64 addr, int hw, bool watch
 			}
 			r_list_free (list);
 		} else {
-			//module holds the address
+			// module holds the address
 			addr = (ut64)r_num_math (dbg->num, module);
 			if (!addr) {
 				return NULL;

diff --git a/libr/debug/p/native/xnu/xnu_threads.c b/libr/debug/p/native/xnu/xnu_threads.c
@@ -195,7 +195,7 @@ static bool xnu_thread_set_gpr(RDebug *dbg, xnu_thread_t *thread) {
 		if (rc == KERN_SUCCESS) {
 			R_LOG_INFO ("convert from self works");
 		} else {
-			R_LOG_WARN ("failed to convert %d", rc);
+			R_LOG_DEBUG ("failed to convert %d", rc);
 		}
 
 		thread->flavor = ARM_UNIFIED_THREAD_STATE;