Style refactoring to elininate jshint warnings. (#62)

Fixing up files to honor .jshintrc. Removing .jscsrc as it's not used by anything.
radanalyticsio · Apr 25, 2017 · 2d90259 · 2d90259
1 parent bc6e5fa
commit 2d90259
Show file tree

Hide file tree

Showing 9 changed files with 530 additions and 498 deletions.
diff --git a/.jscsrc b/.jscsrc
diff --git a/.jshintrc b/.jshintrc
@@ -1,13 +1,21 @@
 {
-  "bitwise": true,
+  "node": true,
   "browser": true,
+  "esnext": true,
+  "bitwise": true,
+  "camelcase": false,
   "curly": true,
   "eqeqeq": true,
-  "esnext": true,
-  "latedef": true,
+  "expr" : true,
+  "immed": true,
+  "indent": 2,
+  "latedef": false,
+  "newcap": false,
   "noarg": true,
-  "node": true,
+  "quotmark": false,
+  "smarttabs": true,
   "strict": true,
+  "sub" : true,
   "undef": true,
   "unused": true,
   "globals": {

diff --git a/app/js/app.js b/app/js/app.js
@@ -9,38 +9,40 @@
 
 
 var app = angular.module('Oshinko', [
-    'ngRoute',
-    'Oshinko.controllers',
-    'Oshinko.factories'
+  'ngRoute',
+  'Oshinko.controllers',
+  'Oshinko.factories'
 ]);
 
 app.config(['$routeProvider', function ($routeProvider) {
-    $routeProvider.when('/clusters/:Id?',
-        {
-            templateUrl: function(params) {
-                if(!params['Id'])
-                    return 'partials/clusters.html';
-                else
-                    return 'partials/cluster-detail.html';
-            },
-            controller: 'ClusterCtrl',
-            activetab: 'clusters'
-        });
-    $routeProvider.when('/login',
-        {
-            templateUrl: 'partials/login.html',
-            controller: 'LoginController',
-            activetab: ''
-        });
-    $routeProvider.otherwise({redirectTo: '/clusters'});
+  $routeProvider.when('/clusters/:Id?',
+    {
+      templateUrl: function (params) {
+        if (!params.Id) {
+          return 'partials/clusters.html';
+        }
+        else {
+          return 'partials/cluster-detail.html';
+        }
+      },
+      controller: 'ClusterCtrl',
+      activetab: 'clusters'
+    });
+  $routeProvider.when('/login',
+    {
+      templateUrl: 'partials/login.html',
+      controller: 'LoginController',
+      activetab: ''
+    });
+  $routeProvider.otherwise({redirectTo: '/clusters'});
 }]);
 
 app.run(function ($http) {
   window.__env = {};
   $http.get('/config/refresh').success(function (result) {
     window.__env.refresh_interval = result;
-  }).error(function(error) {
-    console.log("Unable to fetch refresh interval, using default of 5");
+  }).error(function (error) {
+    console.log("Unable to fetch refresh interval, using default of 5. " + error);
     window.__env.refresh_interval = 5;
   });
 });