Automated Resyntax fixes #1443
Merged
Automated Resyntax fixes #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This `match` expression can be simplified using `match-define`.
The `define` form supports a shorthand for defining functions.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `define-syntax` macro can be replaced with a simpler, equivalent `define-syntax-rule` macro.
This `if` expression can be refactored to an equivalent expression using `and`.
This negated `when` expression can be replaced by an `unless` expression.
This expression is equivalent to calling the `positive?` predicate.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
Providing the same identifier multiple times is unnecessary.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
The `apply` function accepts single arguments in addition to a trailing list argument.
This use of `define-values` is unnecessary.
This `sort` expression can be replaced with a simpler, equivalent expression.
This `map` operation can be replaced with a `for/list` loop.
This quasiquotation is equialent to a simple `list` call.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
jackfirth
reviewed
Mar 21, 2025
Comment on lines
65
to
+69
| (tc-error (~a "structure type constructor applied to non-regular arguments" | ||
| "\n type: " rator | ||
| "\n arguments...: " rands))) | ||
| "\n type: " | ||
| rator | ||
| "\n arguments...: " | ||
| rands))) |
There was a problem hiding this comment.
@sorawee A nice fmt improvement would be to keep description-value pairs adjacent in ~a and similar formatting expressions.
There was a problem hiding this comment.
What exactly are considered "description-value pairs"?
There was a problem hiding this comment.
Some examples:
- The
field v ... ...argument ofraise-arguments-error. - Alternating pairs of strings and expressions in the arguments to
~a,~v,~s, etc.
That is, cases that construct the <field>: <detail> parts of an error message as described in Error Message Conventions. Not sure how easy it is to detect all of these though.
There was a problem hiding this comment.
I agree that it's a good idea for the raise-arguments-error family and the hash family. I don't yet buy that the heuristic described for ~a will work well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 18 files.
single-clause-match-to-match-definelet-to-definedefine-syntax-syntax-rules-to-define-syntax-ruleif-else-false-to-andquasiquote-to-listsort-with-keyed-comparator-to-sort-by-keyzero-comparison-to-positive?define-values-values-to-definedefine-simple-macro-to-define-syntax-parse-ruleif-let-to-condprovide-deduplicationwhen-expression-in-for-loop-to-when-keywordfor/fold-result-keywordinverted-whenmap-to-forapply-flatteningdefine-lambda-to-define