Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide plot2d interface unsafely to avoid excessive overhead #29

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

bennn
Copy link
Contributor

@bennn bennn commented Jan 19, 2018

racket/drracket#185

cc @racket/release

@stamourv
Copy link
Contributor

Do the arguments that made the change safe in the 3d case apply here too?

@bennn
Copy link
Contributor Author

bennn commented Jan 19, 2018

I think so, but I haven't looked carefully yet. Should I do that ASAP, or can it wait until later tonight?

@stamourv
Copy link
Contributor

Later tonight is fine.

@jbclements
Copy link

Many thanks!

@bennn
Copy link
Contributor Author

bennn commented Jan 20, 2018

Yep, plot-snip plot-frame and plot appear safe to provide unsafely.

samth added a commit to samth/plot that referenced this pull request Jan 22, 2018
Provide plot2d interface unsafely to avoid excessive overhead
@stamourv stamourv merged commit f3fe00a into racket:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants