fix: nonfungible api mismatched balance type

[chungquantin]

There is an issue in the nonfungible API that when user calls api::nonfungibles::create, it throws Contract Decode Failed. Reason to that is the mismatched type in the price field of MintSettings in the runtime and in the API crate.

• Remove the balance u32 type in the nonfungibles api crate. Use the primitives::Balance type instead.
• Update all tests in the nonfungible integration tests to test with the min / max value of the data types instead of None.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.43%. Comparing base (27f09da) to head (f0884ff).

@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   64.43%   64.43%           
=======================================
  Files         124      124           
  Lines       23325    23325           
  Branches    23325    23325           
=======================================
  Hits        15029    15029           
  Misses       7637     7637           
  Partials      659      659           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Daanvdplas]

LGTM, lets get this on testnet next!

[evilrobot-01]

LGTM. Made a few improvement suggestions.

Not approving yet as when I try to create a collection by deploying the non-fungibles integration tests contract to local devnet, and calling create, it errors with 'contract reverted'

[evilrobot-01]

The reason for the failure when testing manually was due to the contract not having sufficient balance for the collection deposit. Whilst the goal of these tests is ensuring the non-fungibles pallet works, they perhaps set a bad example, especially as there is no explicit non-fungibles example. I found https://github.com/r0gue-io/pop-api-examples so perhaps that could be migrated across and improved?

Ideally such functions should be payable and should consider a proper flow rather than

pop-node/pop-api/integration-tests/src/nonfungibles/mod.rs

Line 365 in 27f09da

let addr = instantiate(CONTRACT, INIT_VALUE, vec![1]);

.

I'm not suggesting a change here now, just that some proper example is made available which uses a more realistic flow.

[evilrobot-01]

I see we have:

• https://github.com/r0gue-io/pop-api-examples/tree/main/nfts: should be removed imo
• https://github.com/r0gue-io/pop-node/tree/sub0/pop-api/examples/nfts: deprecated, but no reason provided why
• chore: psp34 example contract #386 - unfinished, assuming blocked by drink
• https://github.com/r0gue-io/project-interpop/tree/main/dao_with_nft_verification: slightly different use case

We really just need a simple starter example at https://github.com/r0gue-io/pop-node/tree/main/pop-api/examples.

[chungquantin]

I'll add the example contract for nonfungible in #386 after this PR. Would love to have this PR merged first to resolve the issue on testnet!

[evilrobot-01]

Would love to have this PR merged first to resolve the issue on testnet!

The problem isnt specific to testnet, its v0 of the pop-api crate which would affect any runtime.

[evilrobot-01]

Looks great, thanks for addressing the feedback so promptly.

Will merge once CI is green.