Trim unsigned #58
Open
Trim unsigned #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new feature - the ability to trim a trailing
-unsignedbefore appending-signedto the filename stem. Having a file named-unsigned-signed.apkbothered me and it was easy to fix.I see you've been updating the v1 tag - not what I expected for a release strategy - but in any case, if you choose to merge this you may want to bump to a new version since it adds a new option. It's optional and defaults to the old behavior, but it makes sense as a version bump point.
(This has been rebased on #57 )