GPUでのテスト修正 #194
Merged
GPUでのテスト修正 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandalfr-KY
commented
Jan 10, 2025
Comment on lines
+138
to
140
| if (SCALUQ_USE_CUDA) | ||
| target_compile_options(scaluq PUBLIC $<IF:$<CONFIG:Debug>,-O0 -g,-O3>) | ||
| else() |
There was a problem hiding this comment.
NVCCで -fsanitize=address,undefined としてカンマを用いるとうまくパースできないようでした．
加えてそもそも CUDA と sanitizer の相性が悪いようなので，これ自体を除きます．別のチェッカーを導入してもいいかもしれません．
gandalfr-KY
commented
Jan 10, 2025
| @@ -19,7 +19,7 @@ constexpr Fp eps_() { | |||
| else if constexpr (std::is_same_v<Fp, float>) | |||
| return 1e-4; | |||
| else | |||
| static_assert(internal::lazy_false_v<void>, "unknown GateImpl"); | |||
| static_assert(internal::lazy_false_v<Fp>, "unknown GateImpl"); | |||
There was a problem hiding this comment.
Fpを遅延評価したいのでこうしました．nvccのときのみ引っかかるようです．
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPUでのテストのコンパイルが通らなかったので修正しました（手元でパスすることを確認）．
また，実行に時間がかかりすぎることもあり，テストのサイズを若干下げました．