Add batch update #191
Merged
Add batch update #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, add batched control test
…bablistic's batch update
gandalfr-KY
reviewed
Dec 23, 2024
src/gate/gate.cpp
Outdated
| std::uint64_t full_mask = (1ULL << states.n_qubits()) - 1; | ||
| if ((_target_mask | _control_mask) > full_mask) [[unlikely]] { | ||
| throw std::runtime_error( | ||
| "Error: Gate::update_quantum_state(StateVector& state): " |
There was a problem hiding this comment.
エラーメッセージは StateVectorBached& state ですかね
gandalfr-KY
reviewed
Dec 24, 2024
src/state/state_vector.cpp
Outdated
| @@ -11,6 +11,9 @@ StateVector<Fp>::StateVector(std::uint64_t n_qubits) | |||
| set_zero_state(); | |||
| } | |||
| FLOAT(Fp) | |||
| StateVector<Fp>::StateVector(Kokkos::View<ComplexType*> view) | |||
| : _dim(view.extent(0)), _raw(view), _n_qubits(std::bit_width(_dim) - 1) {} | |||
There was a problem hiding this comment.
C++のコンストラクタでのメンバの初期化についてなんですが，メンバを宣言した順番に走るので，
_n_qubits, _dim, _raw の順で初期化されることになります．なのでこのままだと _n_qubits(std::bit_width(_dim) - 1) が不定値になると思います
There was a problem hiding this comment.
その他 warning の解消もお願いします！
https://github.com/qulacs/scaluq/actions/runs/12424606202/job/34690035129
…ds for BatchedStateVector, reorder constructor of StateVector(Kokkos::View<ComplexType*> view)
KowerKoint
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add batchを精度指定に対応しました。
先にStateVectorBatchedのマージをして、cirquitの配列を受け取るのは別ブランチでやります。