change method name #161
Merged
change method name #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gandalfr-KY
commented
Aug 27, 2024
gandalfr-KY
commented
| class | old_name | new_name | description |
|---|---|---|---|
| Circuit | gate_count | n_gates | 違和感ありました 異論あれば遠慮なく |
| Gate/ParamGate | get_*_qubit_list/mask | *_qubit_list/mask | |
| PauliGate 他 | get_pauli_id_list | pauli_id_list | |
| StateVector(Batched) | amplitudes | get_amplitudes | GPUからの転送コスト大 |
|
ついでに触れると |
Closed
|
Circuit::get、qulacsの人がCircuitのことを配列と同じインターフェースで使ってほしくてつけたんだろうけど、sizeはgate_countだし微妙なので、get_gate_atとかでいいかも |
KowerKoint
reviewed
Sep 3, 2024
| @@ -25,12 +25,12 @@ class StateVector { | |||
| /** | |||
| * @attention Very slow. You should use load() instead if you can. | |||
| */ | |||
| void set_amplitude_at_index(std::uint64_t index, const Complex& c); | |||
| void set_amplitude_at(std::uint64_t index, const Complex& c); | |||
There was a problem hiding this comment.
_atに統一できていてかなりわかりやすいです！
ありがとうございます
|
ParamGateの命名変更もついでに対応しました。 |
|
追加で変更した分のまとめです
|
|
ParamGateの変更もOKです！ありがとうございます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.