Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace log using log/slog #76

Closed
wants to merge 1 commit into from
Closed

Replace log using log/slog #76

wants to merge 1 commit into from

Conversation

jiayx
Copy link

@jiayx jiayx commented Nov 12, 2024

Replace log using log/slog

Copy link

google-cla bot commented Nov 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jiayx
Copy link
Author

jiayx commented Nov 12, 2024

#56

@marten-seemann
Copy link
Member

This PR is missing the point of of slog/log. There no value in just replacing all log calls with slog.

The value comes from users being able to provide their own loggers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants