Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract system: solve deadlock in cyclic calling patterns that is now possible due to __qpiCallSystemProcOfOtherContract() #296

Closed
philippwerner opened this issue Feb 4, 2025 · 1 comment · Fixed by #301
Closed

Contract system: solve deadlock in cyclic calling patterns that is now possible due to __qpiCallSystemProcOfOtherContract() #296

philippwerner opened this issue Feb 4, 2025 · 1 comment · Fixed by #301
Assignees
@philippwerner
Milestone
2025-02-10 Sprint 3

Comments

@philippwerner
Copy link
Contributor

philippwerner commented Feb 4, 2025 •
edited
Loading

The QVAULT contract wants to invoke QX::TransferShareManagementRights() in order to acquire asset management rights, but this leads to a deadlock when qpi.releaseShares() in QX wants to lock the contract state of QVAULT for invoking the PRE_ACQUIRE_SHARES callback. This and similar patterns not involving a contract function running in parallel, can be solved in this iteration.
@philippwerner philippwerner self-assigned this Feb 4, 2025
@philippwerner philippwerner converted this from a draft issue Feb 4, 2025
@philippwerner philippwerner added this to the 2025-02-10 Sprint 3 milestone Feb 4, 2025
@philippwerner philippwerner moved this from 📋 Backlog to 🏗 In progress in qubic Feb 5, 2025
@philippwerner philippwerner mentioned this issue Feb 7, 2025
Merged
@philippwerner philippwerner linked a pull request Feb 7, 2025 that will close this issue
Solve contract deadlocks delaying progress of QVAULT #301
Merged
@philippwerner philippwerner mentioned this issue Feb 7, 2025
Closed
@philippwerner
Copy link
Contributor Author

Issue #302 is the follow-up issue.

@philippwerner philippwerner moved this from 🏗 In progress to 🧪 Testing in qubic Feb 7, 2025
@philippwerner philippwerner moved this from 🧪 Testing to ✅ Done in qubic Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippwerner philippwerner

Labels
None yet
Projects
qubic
Status: ✅ Done
Milestone
2025-02-10 Sprint 3
Development

Successfully merging a pull request may close this issue.

Solve contract deadlocks delaying progress of QVAULT qubic/core
1 participant
@philippwerner