-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init Back to top #585
Open
SenChung
wants to merge
13
commits into
develop
Choose a base branch
from
QOLOE-797-back-to-top
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
init Back to top #585
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e5a83af
init Back to top
SenChung 08a6ac2
Changes to make to Back to top btn dynamic
SenChung 2bb5b73
QOLOE-797 back to top set default text
SenChung a693a5b
changed the dynamic behaviour
SenChung 9a18987
fixed: html data attribute and js logic
SenChung 160b0b3
Merge branch 'develop' into QOLOE-797-back-to-top
elvishu ff85d6b
fix: Back to top aligned to Figma requirement
SenChung 54f0d0d
Merge branch 'develop' into QOLOE-797-back-to-top
SenChung 947b1e1
fix: updated back to top btn
SenChung d225116
fix: Added Requested changes
SenChung 55927fc
fix: lint fix
SenChung 1409645
fix: js logic scope error
SenChung f13a144
fix: trying to fix the "Failed to build the preview" error
SenChung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
{ | ||
"hide_back_to_top": false | ||
"hide_back_to_top": false, | ||
"text":"Back to top", | ||
"dynamic":false, | ||
"offset": 100 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{{#unless hide_back_to_top}} | ||
<div class="qld__widgets"> | ||
<a href="#" id="backToTop" class="qld__btn qld__btn--floating qld__btn--back-to-top" aria-label="Back to top"> | ||
<span>Back to top</span> | ||
<div class="qld__widgets {{#if dynamic}}fixed{{/if}}"> | ||
<a href="#" id="backToTop" class="qld__btn qld__btn--floating qld__btn--back-to-top show" data-offset="{{offset}}" data-dynamic="{{dynamic}}" aria-label="{{text}}"> | ||
<span>{{text}}</span> | ||
</a> | ||
</div> | ||
{{/unless}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have 'default' if 'text' is not set, i.e. 'Back to top'
offset default should be '100'.
Also why is dynamic when true == fix.
and data-dynamic default if not set is 'false'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These issues are now fixed with the latest push