Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QM driver for new sequence layout #974

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Update QM driver for new sequence layout #974

merged 3 commits into from
Aug 13, 2024

Conversation

stavros11
Copy link
Member

Updates QM driver to work with the PulseSequence layout introduced in #965. Resonator spectroscopy, single shot classification and Rabi routines work.

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.

Project coverage is 42.91%. Comparing base (038304c) to head (e6f7a89).

Files Patch % Lines
src/qibolab/instruments/qm/controller.py 12.00% 22 Missing ⚠️
src/qibolab/instruments/qm/program/instructions.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              0.2     #974   +/-   ##
=======================================
  Coverage   42.90%   42.91%           
=======================================
  Files          80       80           
  Lines        5505     5502    -3     
=======================================
- Hits         2362     2361    -1     
+ Misses       3143     3141    -2     
Flag Coverage Δ
unittests 42.91% <9.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stavros11 stavros11 changed the title fix: update QM driver for new sequence layout Update QM driver for new sequence layout Aug 11, 2024
@alecandido alecandido force-pushed the remove-characterization branch from 3088f0d to af0d7f9 Compare August 13, 2024 09:24
Base automatically changed from remove-characterization to 0.2 August 13, 2024 10:12
@stavros11
Copy link
Member Author

I rebased to 0.2 after the latest merges and tested again the usual routines and they work. This just updates the driver for the latest changes without introducing new features so we could probably merge. For new features we already have issues and I will introduce them in separate PRs.

@alecandido alecandido added this to the Qibolab 0.2.0 milestone Aug 13, 2024
@stavros11 stavros11 merged commit 52c0862 into 0.2 Aug 13, 2024
21 of 22 checks passed
@stavros11 stavros11 deleted the fix-qm-sequence branch August 13, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants