Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transpiler-related tutorial #763

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Conversation

alecandido
Copy link
Member

The transpiler has been moved to Qibo a while ago, so I'd consider this a leftover. In
case there is something to be moved before dropping here (or right after) let's do it
quickly, or otherwise postpone it until it will be relevant (i.e. let's not block the
update of Qibolab behind the update of Qibo, since having two outdated docs is worse
than a single one).

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1723585) 62.54% compared to head (c1596a3) 62.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   62.54%   62.54%           
=======================================
  Files          47       47           
  Lines        5882     5882           
=======================================
  Hits         3679     3679           
  Misses       2203     2203           
Flag Coverage Δ
unittests 62.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stavros11
Copy link
Member

Thanks @alecandido. I agree with removing, I would just prefer to open a PR copying this in Qibo before merging, so that it does not get lost in the abyss. Unless it is already there. I can have a look and do it.

@stavros11
Copy link
Member

I had a look in Qibo and there is already an example about how to modify the transpiler, so no need to move anything there. However, the tutorial here also talks about how to modify the compiler and plug it to the QibolabBackend which is not covered in Qibo and is still part of qibolab code. Therefore, I would only remove the transpiler part and keep the rest, maybe modifying the title and the text a bit.

@alecandido I can do it pushing to this branch, if you agree.

@alecandido alecandido force-pushed the remove-transpiler-tutorial branch from e80bb21 to f26a070 Compare January 17, 2024 10:24
@alecandido
Copy link
Member Author

I had a look in Qibo and there is already an example about how to modify the transpiler, so no need to move anything there.

Sorry: I actually already had a look yesterday, so I knew it (I could have written in the OP).

However, the tutorial here also talks about how to modify the compiler and plug it to the QibolabBackend which is not covered in Qibo and is still part of qibolab code. Therefore, I would only remove the transpiler part and keep the rest, maybe modifying the title and the text a bit.

@alecandido I can do it pushing to this branch, if you agree.

If you wish, that's fine. Just change the name of the file and title with the substitution transpiler -> compiler, and truncate the transpiler-specific part.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecandido I did some modifications so that the tutorial focuses on the compiler that is still in qibolab. If you agree, feel free to merge.

@alecandido alecandido force-pushed the remove-transpiler-tutorial branch from eb3c401 to c1596a3 Compare January 20, 2024 21:40
@alecandido alecandido merged commit 0d019bb into main Jan 20, 2024
21 checks passed
@alecandido alecandido deleted the remove-transpiler-tutorial branch January 20, 2024 22:58
@alecandido alecandido added this to the Qibolab 0.1.5 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants