Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port exact from_array from qualang_tools #1148

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Port exact from_array from qualang_tools #1148

merged 1 commit into from
Feb 18, 2025

Conversation

stavros11
Copy link
Member

Fixes #1147.

Originally in #1131 I tried to make my own from_array based on qualang_tools, but as noted in #1147 this did not turn out well, so here I decided to port the function as is.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 52.60%. Comparing base (74d98c6) to head (353cbd7).

Files with missing lines Patch % Lines
src/qibolab/_core/instruments/qm/program/loops.py 0.00% 52 Missing ⚠️
...bolab/_core/instruments/qm/program/instructions.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   52.73%   52.60%   -0.14%     
==========================================
  Files          70       71       +1     
  Lines        3165     3173       +8     
==========================================
  Hits         1669     1669              
- Misses       1496     1504       +8     
Flag Coverage Δ
unittests 52.60% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ElStabilini ElStabilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully ran a chevron, so it seems to be working for me, thank you @stavros11 !

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally in #1131 I tried to make my own from_array based on qualang_tools, but as noted in #1147 this did not turn out well, so here I decided to port the function as is.

To me, that's an optimal quick fix solution.

We can decide later on to take some more time to improve the code, or smoothen details to make it closer to your implementation.
In any case, better to decouple this from the need and pressure to have a working driver.

Thanks!

@stavros11 stavros11 merged commit b929bac into main Feb 18, 2025
63 of 64 checks passed
@stavros11 stavros11 deleted the fix-qm-loops branch February 18, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with chevron acquisition
3 participants