Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compiler rule #1057

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fixing compiler rule #1057

merged 1 commit into from
Oct 3, 2024

Conversation

alecandido
Copy link
Member

Port #1044 to 0.2.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.95%. Comparing base (4128ac7) to head (05de58d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   51.95%   51.95%           
=======================================
  Files          63       63           
  Lines        2808     2808           
=======================================
  Hits         1459     1459           
  Misses       1349     1349           
Flag Coverage Δ
unittests 51.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it but I have no reason to believe that it will not work with 0.2

@alecandido alecandido merged commit b1213fe into main Oct 3, 2024
40 checks passed
@alecandido alecandido deleted the fix-compiler branch October 3, 2024 10:47
@alecandido alecandido added this to the Qibolab 0.2.1 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants