Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kernel based weights being generated multiple times #1000

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hay-k
Copy link
Contributor

@hay-k hay-k commented Aug 21, 2024

Fixes the issue described here

Previously, when qubit kernels were available, the calculated weight was not stored in the weights dict, hence when needed it was recalculated, resulting into different laboneq pulse objects (even though the contained data was exactly the same, the IDs of the objects were different), causing the mentioned issue.

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you are right about what you mentioned on the issue

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (9bbbbe8) to head (c6704ad).
Report is 2 commits behind head on 0.1.

Files Patch % Lines
src/qibolab/instruments/zhinst/executor.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.1    #1000      +/-   ##
==========================================
+ Coverage   70.24%   70.27%   +0.03%     
==========================================
  Files          64       64              
  Lines        6701     6698       -3     
==========================================
  Hits         4707     4707              
+ Misses       1994     1991       -3     
Flag Coverage Δ
unittests 70.27% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now also qiboteam/qibolab_platforms_qrc#167 works for me.
With the loaded kernels the fidelity drops which makes sense
http://login.qrccluster.com:9000/5SWd0VlIQv6sucWCVu6KEw==

@hay-k hay-k merged commit bbac7cf into 0.1 Aug 21, 2024
33 checks passed
@stavros11 stavros11 deleted the fix-kernel-handling branch August 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants