Skip to content

Commit

Permalink
feat: Remove modulated waveforms access from pulses
Browse files Browse the repository at this point in the history
  • Loading branch information
alecandido committed Jan 29, 2024
1 parent 24d8669 commit 474d72d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 22 deletions.
18 changes: 0 additions & 18 deletions src/qibolab/pulses/pulse.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,24 +128,6 @@ def envelope_waveforms(self, sampling_rate=SAMPLING_RATE):
self.shape.envelope_waveform_q(sampling_rate),
)

def modulated_waveform_i(self, sampling_rate=SAMPLING_RATE) -> Waveform:
"""The waveform of the i component of the pulse, modulated with its
frequency."""

return self.shape.modulated_waveform_i(sampling_rate)

def modulated_waveform_q(self, sampling_rate=SAMPLING_RATE) -> Waveform:
"""The waveform of the q component of the pulse, modulated with its
frequency."""

return self.shape.modulated_waveform_q(sampling_rate)

def modulated_waveforms(self, sampling_rate):
"""A tuple with the i and q waveforms of the pulse, modulated with its
frequency."""

return self.shape.modulated_waveforms(sampling_rate)

def __hash__(self):
"""Hash the content.
Expand Down
6 changes: 2 additions & 4 deletions src/qibolab/pulses/shape.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,9 @@ def __init__(self, msg=None, *args):


class PulseShape(ABC):
"""Abstract class for pulse shapes.
"""Pulse envelopes.
This object is responsible for generating envelope and modulated
waveforms from a set of pulse parameters and its type. Generates
both i (in-phase) and q (quadrature) components.
Generates both i (in-phase) and q (quadrature) components.
"""

pulse = None
Expand Down

0 comments on commit 474d72d

Please sign in to comment.