Skip to content

Commit

Permalink
increase limit && change reading order to favor XMP
Browse files Browse the repository at this point in the history
  • Loading branch information
qdraw committed Nov 11, 2024
1 parent f735364 commit c2a8fee
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 20 deletions.
38 changes: 19 additions & 19 deletions starsky/starsky.foundation.readmeta/ReadMetaHelpers/ReadMetaExif.cs
Original file line number Diff line number Diff line change
Expand Up @@ -557,35 +557,35 @@ private static string GetXmpData(Directory? exifItem, string propertyPath)
return result;
}

public static string GetObjectName(List<Directory> allExifItems)
public static string? GetObjectName(List<Directory> allExifItems)
{
var iptcDirectory = allExifItems.OfType<IptcDirectory>().FirstOrDefault();

var objectName = iptcDirectory?.Tags.FirstOrDefault(
p => p.Name == "Object Name")?.Description;

if ( !string.IsNullOrEmpty(objectName) )
{
return objectName;
}

// Xmp readings
var xmpDirectory = allExifItems.OfType<XmpDirectory>().FirstOrDefault();
return GetXmpData(xmpDirectory, "dc:title[1]");
var xmpTitle = GetXmpData(xmpDirectory, "dc:title[1]");
if ( !string.IsNullOrEmpty(xmpTitle) )
{
return xmpTitle;
}

var iptcDirectory = allExifItems.OfType<IptcDirectory>().FirstOrDefault();
var iptcObjectName = iptcDirectory?.Tags.FirstOrDefault(
p => p.Name == "Object Name")?.Description;
return iptcObjectName;
}

public static string GetCaptionAbstract(List<Directory> allExifItems)
public static string? GetCaptionAbstract(List<Directory> allExifItems)
{
var iptcDirectory = allExifItems.OfType<IptcDirectory>().FirstOrDefault();
var caption = iptcDirectory?.GetDescription(IptcDirectory.TagCaption);
var xmpDirectory = allExifItems.OfType<XmpDirectory>().FirstOrDefault();
var xmpCaption = GetXmpData(xmpDirectory, "dc:description[1]");

if ( !string.IsNullOrEmpty(caption) )
if ( !string.IsNullOrEmpty(xmpCaption) )
{
return caption;
return xmpCaption;
}

var xmpDirectory = allExifItems.OfType<XmpDirectory>().FirstOrDefault();
return GetXmpData(xmpDirectory, "dc:description[1]");
var iptcDirectory = allExifItems.OfType<IptcDirectory>().FirstOrDefault();
var caption = iptcDirectory?.GetDescription(IptcDirectory.TagCaption);
return caption;
}

public static string GetExifKeywords(List<Directory> allExifItems)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ const DetailViewSidebar: React.FunctionComponent<IDetailViewSidebarProps> = memo
});
setCollections(collectionsList);
}

// For the display
const [formEnabled, setFormEnabled] = React.useState(true);
useEffect(() => {
Expand Down Expand Up @@ -216,7 +217,7 @@ const DetailViewSidebar: React.FunctionComponent<IDetailViewSidebarProps> = memo
<h4>{MessageInfoName}</h4>
<FormControl
onBlur={handleChange}
maxlength={1024}
maxlength={5000}
name="description"
reference={descriptionReference}
contentEditable={formEnabled}
Expand Down

0 comments on commit c2a8fee

Please sign in to comment.