From 3ca7b162146a2bb02c248d9594cc0dce88d071ac Mon Sep 17 00:00:00 2001
From: Dion <qdraw@users.noreply.github.com>
Date: Thu, 14 Dec 2023 21:45:27 +0100
Subject: [PATCH] small code smells

---
 .../starsky/clientapp/src/components/atoms/modal/modal.tsx   | 2 +-
 .../starsky/clientapp/src/components/atoms/portal/portal.tsx | 2 +-
 .../list-image-view-select-container.tsx                     | 5 +----
 .../src/components/organisms/menu-search/menu-search.tsx     | 4 ++--
 .../organisms/modal-edit-date-time/modal-edit-datetime.tsx   | 4 ++--
 starsky/starsky/clientapp/src/containers/archive.tsx         | 4 +---
 6 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/starsky/starsky/clientapp/src/components/atoms/modal/modal.tsx b/starsky/starsky/clientapp/src/components/atoms/modal/modal.tsx
index f296a24cdf..5d1173368d 100644
--- a/starsky/starsky/clientapp/src/components/atoms/modal/modal.tsx
+++ b/starsky/starsky/clientapp/src/components/atoms/modal/modal.tsx
@@ -1,5 +1,5 @@
 import "core-js/features/dom-collections/for-each";
-import { ReactNode, useEffect, useRef, useState } from "react";
+import React, { ReactNode, useEffect, useRef, useState } from "react";
 import ReactDOM from "react-dom";
 import useGlobalSettings from "../../../hooks/use-global-settings";
 import { Language } from "../../../shared/language";
diff --git a/starsky/starsky/clientapp/src/components/atoms/portal/portal.tsx b/starsky/starsky/clientapp/src/components/atoms/portal/portal.tsx
index d1eeb64e40..6292fd7f96 100644
--- a/starsky/starsky/clientapp/src/components/atoms/portal/portal.tsx
+++ b/starsky/starsky/clientapp/src/components/atoms/portal/portal.tsx
@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import React, { useEffect, useState } from "react";
 import ReactDOM from "react-dom";
 
 type PortalPropTypes = {
diff --git a/starsky/starsky/clientapp/src/components/molecules/list-image-view-select-container/list-image-view-select-container.tsx b/starsky/starsky/clientapp/src/components/molecules/list-image-view-select-container/list-image-view-select-container.tsx
index 6ce3164116..67ae28ae77 100644
--- a/starsky/starsky/clientapp/src/components/molecules/list-image-view-select-container/list-image-view-select-container.tsx
+++ b/starsky/starsky/clientapp/src/components/molecules/list-image-view-select-container/list-image-view-select-container.tsx
@@ -21,10 +21,7 @@ const ListImageViewSelectContainer: React.FunctionComponent<IListImageBox> =
   memo(({ item, className: propsClassName, onSelectionCallback, children }) => {
     if (item.isDirectory === undefined) item.isDirectory = false;
 
-    const [className] = React.useState(
-      !propsClassName ? "list-image-box" : propsClassName
-    );
-
+    const className = !propsClassName ? "list-image-box" : propsClassName;
     const history = useLocation();
 
     // Check if select exist or Length 0 or more
diff --git a/starsky/starsky/clientapp/src/components/organisms/menu-search/menu-search.tsx b/starsky/starsky/clientapp/src/components/organisms/menu-search/menu-search.tsx
index e62d47b858..ed978722c4 100644
--- a/starsky/starsky/clientapp/src/components/organisms/menu-search/menu-search.tsx
+++ b/starsky/starsky/clientapp/src/components/organisms/menu-search/menu-search.tsx
@@ -140,7 +140,7 @@ export const MenuSearch: React.FunctionComponent<IMenuSearchProps> = ({
 
           {/* when selected */}
           {select ? (
-            <div
+            <button
               className={"item item--labels"}
               onClick={() => toggleLabels()}
               onKeyDown={(event) => {
@@ -148,7 +148,7 @@ export const MenuSearch: React.FunctionComponent<IMenuSearchProps> = ({
               }}
             >
               Labels
-            </div>
+            </button>
           ) : null}
 
           {/* More menu - When in normal state */}
diff --git a/starsky/starsky/clientapp/src/components/organisms/modal-edit-date-time/modal-edit-datetime.tsx b/starsky/starsky/clientapp/src/components/organisms/modal-edit-date-time/modal-edit-datetime.tsx
index f34b972857..f2aedce775 100644
--- a/starsky/starsky/clientapp/src/components/organisms/modal-edit-date-time/modal-edit-datetime.tsx
+++ b/starsky/starsky/clientapp/src/components/organisms/modal-edit-date-time/modal-edit-datetime.tsx
@@ -1,4 +1,4 @@
-import { useState } from "react";
+import React, { useState } from "react";
 import useGlobalSettings from "../../../hooks/use-global-settings";
 import { IFileIndexItem } from "../../../interfaces/IFileIndexItem";
 import {
@@ -43,7 +43,7 @@ const ModalEditDatetime: React.FunctionComponent<IModalDatetimeProps> = (
     "The date and time were entered incorrectly"
   );
 
-  const [isFormEnabled] = useState(true);
+  const isFormEnabled = true;
 
   const [fullYear, setFullYear] = useState(parseDateYear(props.dateTime));
   const [month, setMonth] = useState(parseDateMonth(props.dateTime));
diff --git a/starsky/starsky/clientapp/src/containers/archive.tsx b/starsky/starsky/clientapp/src/containers/archive.tsx
index d1e1d5879a..ee121d134d 100644
--- a/starsky/starsky/clientapp/src/containers/archive.tsx
+++ b/starsky/starsky/clientapp/src/containers/archive.tsx
@@ -12,9 +12,7 @@ import { URLPath } from "../shared/url-path";
 function Archive(archive: Readonly<IArchiveProps>) {
   const history = useLocation();
 
-  const [iconList] = React.useState(
-    !new URLPath().StringToIUrl(history.location.search).list
-  );
+  const iconList = !new URLPath().StringToIUrl(history.location.search).list;
 
   // The sidebar
   const [sidebar, setSidebar] = React.useState(