add fix for code smells

starsky/starsky/clientapp/src/hooks/use-filelist.spec.tsx

@@ -1,6 +1,6 @@
 import { act } from "react-dom/test-utils";
-import { newIArchive } from "../interfaces/IArchive";
-import { PageType } from "../interfaces/IDetailView";
+import { IArchive, newIArchive } from "../interfaces/IArchive";
+import { IRelativeObjects, PageType } from "../interfaces/IDetailView";
 import {
   newIFileIndexItem,
   newIFileIndexItemArray
@@ -11,6 +11,8 @@ import useFileList, {
   IFileList,
   fetchContentUseFileList
 } from "./use-filelist";
+import * as fetchUseFileListContentCache from "./use-filelist";
+import { render } from "@testing-library/react";
 
 describe("UseFileList", () => {
   describe("Archive", () => {
@@ -76,6 +78,57 @@ describe("UseFileList", () => {
       expect(hook2).toBeCalledTimes(1);
     });
 
+    const TestComponent = () => {
+      useFileList("mockLocationSearch", true);
+
+      // You can use the result object to interact with the state or render UI components
+
+      return null;
+    };
+
+    xit("should call setArchive when pageType is Archive", async () => {
+      // Mock fetchUseFileListContentCache to resolve immediately
+      const fetchSpy = jest
+        .spyOn(fetchUseFileListContentCache, "fetchUseFileListContentCache")
+        .mockResolvedValue();
+
+      // Render the component
+      let result: any;
+      await act(async () => {
+        result = render(<TestComponent />);
+      });
+
+      // Trigger the setPageTypeHelper with a response object having pageType: Archive
+      const responseObject = {
+        pageType: "Archive",
+        data: {
+          fileIndexItems: [],
+          pageType: "Archive",
+          subPath: "/test",
+          breadcrumb: [],
+          colorClassUsage: [],
+          collections: true,
+          lastEdited: "",
+          lastEditedUtc: "",
+          parentDirectory: "",
+          relativeObjects: {} as IRelativeObjects,
+          colorClassActiveList: [],
+          collectionsCount: 0,
+          isReadOnly: false,
+          dateCache: Date.now()
+        } as IArchive
+      };
+      await act(async () => {
+        result.current.setPageTypeHelper(responseObject);
+      });
+
+      // Assert that setArchive has been called with the expected data
+      expect(result.current).toBe(responseObject.data as unknown as IArchive);
+
+      // Clean up the spies
+      fetchSpy.mockRestore();
+    });
+
     it("with detailview content 200", async () => {
       const hook = jest.fn();
       const hook2 = jest.fn();
@@ -179,6 +232,7 @@ describe("UseFileList", () => {
       const { hook } = mounter();
       const cacheGetSpy = jest
         .spyOn(FileListCache.prototype, "CacheGet")
+        .mockReset()
         .mockImplementationOnce(() => {
           return { ...newIArchive(), dateCache: Date.now() };
         });
@@ -195,13 +249,15 @@ describe("UseFileList", () => {
     });
 
     it("check cache first and then query", async () => {
-      const { hook } = mounter();
       const cacheSetSpy = jest
         .spyOn(FileListCache.prototype, "CacheGet")
+        .mockReset()
         .mockImplementationOnce(() => {
           return null;
         });
 
+      const { hook } = mounter();
+
       setFetchSpy(200, PageType.Archive);
 
       hook.fetchUseFileListContentCache(

starsky/starsky/clientapp/src/hooks/use-filelist.ts

@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { SetStateAction, useEffect, useState } from "react";
 import { IArchive, newIArchive } from "../interfaces/IArchive";
 import {
   IDetailView,
@@ -21,7 +21,7 @@ export interface IFileList {
     abortController: AbortController,
     setPageTypeHelper: (responseObject: any) => void,
     resetPageTypeBeforeLoading: boolean,
-    setPageType: (value: React.SetStateAction<PageType>) => void
+    setPageType: (value: SetStateAction<PageType>) => void
   ) => Promise<void>;
 }
 
@@ -31,7 +31,7 @@ export const fetchContentUseFileList = async (
   abortController: AbortController,
   setPageTypeHelper: (responseObject: any) => void,
   resetPageTypeBeforeLoading: boolean,
-  setPageType: (value: React.SetStateAction<PageType>) => void
+  setPageType: (value: SetStateAction<PageType>) => void
 ): Promise<void> => {
   try {
     // force start with a loading icon
@@ -66,7 +66,7 @@ export const fetchContentUseFileList = async (
   }
 };
 
-const fetchUseFileListContentCache = async (
+export const fetchUseFileListContentCache = async (
   locationLocal: string,
   locationSearch: string,
   abortController: AbortController,
@@ -124,14 +124,12 @@ const useFileList = (
     setPageType(responseObject.pageType);
     switch (responseObject.pageType) {
       case PageType.Archive:
-        const archiveMedia = new CastToInterface().MediaArchive(responseObject);
-        setArchive(archiveMedia.data);
+        setArchive(new CastToInterface().MediaArchive(responseObject).data);
         break;
       case PageType.DetailView:
-        const detailViewMedia = new CastToInterface().MediaDetailView(
-          responseObject
+        setDetailView(
+          new CastToInterface().MediaDetailView(responseObject).data
         );
-        setDetailView(detailViewMedia.data);
         break;
       default:
         break;
@@ -147,7 +145,9 @@ const useFileList = (
       setPageTypeHelper,
       resetPageTypeBeforeLoading,
       setPageType
-    );
+    ).then(() => {
+      // do nothing
+    });
 
     return () => {
       abortController.abort();