Correct Unexpected floats when reading LI L2 LFL

[ClementLaplace]

Makes sure that the method apply_fill_value is not applied when _FillaValue is not into the attributes. It is fixing the bug mentioned there #2854 .

• Closes Unexpected floats when reading LI L2 LFL data #2854

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (17cf0ce) to head (f29d190).
Report is 116 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
- Coverage   96.14%   96.12%   -0.03%     
==========================================
  Files         383      383              
  Lines       55785    55691      -94     
==========================================
- Hits        53636    53534     -102     
- Misses       2149     2157       +8     

Flag	Coverage Δ
behaviourtests	3.88% <0.00%> (+<0.01%)	⬆️
unittests	96.22% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coveralls]

Pull Request Test Coverage Report for Build 12991062112

Details

• 22 of 22 (100.0%) changed or added relevant lines in 4 files are covered.
• 3 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.005%) to 96.217%

---

Files with Coverage Reduction	New Missed Lines	%
satpy/tests/reader_tests/_li_test_utils.py	1	98.55%
satpy/readers/li_base_nc.py	1	99.62%
satpy/tests/reader_tests/test_li_l2_nc.py	1	99.53%

Totals
Change from base Build 12905542942:	-0.005%
Covered Lines:	53761
Relevant Lines:	55875

---

💛 - Coveralls

[ameraner]

Thanks for the investigations! I left some comments in the code.

I am also wondering if we still also need the fix for the float64 upcasting when multiplying with the scale_factor, as discussed in the issue...

[ameraner]

Thanks for the fix and the extra more comprehensive tests! Just two things inline.

[ameraner]

LGTM, thanks!

[pnuu]

One suggestion inline.

Maybe we should start splitting the long test helpers to smaller chunks at some point?

I also restarted the one windows CI run.

[pnuu]

Other than the numerous formatting suggestions, looks good to me.

[pnuu]

LGTM, thanks for this!

Could you update the description so that it describes the changes? In addition to the currently mentioned float32, there are also plenty of small unrelated changes in the tests and test utilis.

[ClementLaplace]

i

LGTM, thanks for this!

Could you update the description so that it describes the changes? In addition to the currently mentioned float32, there are also plenty of small unrelated changes in the tests and test utilis.

@pnuu Thanks for your feedback, the unrelated changes is done because at some point the CI/CD pipeline was not working anymore (see this commit) hence I have merged the main branch to the fix_li_lfl_float branch (see this commit), it has enable the pipeline to work again.