Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotation to PyTorch/XLA code and tests & expand tests for various types as needed #8627

Open
miladm opened this issue Jan 26, 2025 · 1 comment
Assignees
Labels
TECHNICAL_DEBT Technical Debt Is Evil usability Bugs/features related to improving the usability of PyTorch/XLA

Comments

@miladm
Copy link
Collaborator

miladm commented Jan 26, 2025

🐛 Bug

Most of the code in PyTorch/XLA does not have type annotations, and almost everything shows up as Any if you use a type checker. Let's fix that! Once we have good coverage, we can add a type checker to the CI to help us catch bugs.

Please file child bugs for specific files/modules as you go.

typing module reference: https://docs.python.org/3/library/typing.html

Please introduce a plan for the target code to be addressed by this bug and a corresponding set of tests to expand on.

@miladm miladm added TECHNICAL_DEBT Technical Debt Is Evil usability Bugs/features related to improving the usability of PyTorch/XLA labels Jan 26, 2025
@miladm
Copy link
Collaborator Author

miladm commented Jan 26, 2025

@ysiraichi can you please take over this issue. @zpcore plz assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TECHNICAL_DEBT Technical Debt Is Evil usability Bugs/features related to improving the usability of PyTorch/XLA
Projects
None yet
Development

No branches or pull requests

3 participants