Fix Int4WeightEmbeddingQATQuantizer.convert path #2024
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2024
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 270a859 with merge base 5a78b70 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
**Summary:** Fixes the issue where
`Int4WeightEmbeddingQATQuantizer`'s convert path assigned the
scales and zero points to the wrong attributes ("scales" and
"zeros" instead of "scale" and "zero point"), and also ensures
the precisions are correctly set.
**Test Plan:**
python test/quantization/test_qat.py -k test_qat_4w_embedding
andrewor14
force-pushed
the
fix-embedding-qat
branch
from
bcd64bf to
270a859
Compare
|
@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixes the issue where
Int4WeightEmbeddingQATQuantizer's convert path assigned the scales and zero points to the wrong attributes ("scales" and "zeros" instead of "scale" and "zero point"), and also ensures the precisions are correctly set.Test Plan:
python test/quantization/test_qat.py -k test_qat_4w_embedding