Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Testtest_galore_quant.py for ROCm #1983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petrex
Copy link
Collaborator

@petrex petrex commented Mar 31, 2025

This pull request includes a change to the test/quantization/test_galore_quant.py file to improve the test environment handling. The most important change is the addition of a condition to skip the entire test if CUDA is not available or if ROCM is enabled.

Test environment handling:

  • test/quantization/test_galore_quant.py: Added a condition to skip the entire test if CUDA is not available or if ROCM is enabled, ensuring compatibility and avoiding test failures in unsupported environments.

…s enabled, improving test reliability across different environments.
Copy link

pytorch-bot bot commented Mar 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1983

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 9c8e93a with merge base 42e1345 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2025
@petrex petrex added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 31, 2025
@petrex petrex requested a review from Copilot April 1, 2025 00:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test environment handling in test/quantization/test_galore_quant.py to skip the test when CUDA is not available or when running on ROCm.

  • Added a conditional check to determine the appropriate test environment
  • Skips the test with a custom message when conditions indicate incompatibility
Comments suppressed due to low confidence (1)

test/quantization/test_galore_quant.py:18

  • [nitpick] Consider clarifying the condition by explicitly checking for ROCm support (for example, by using a dedicated helper function or a more descriptive comment) to improve readability and maintenance.
if not torch.cuda.is_available() or torch.version.hip is not None:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants