Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send given and family name for invoice info #4396

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Mar 11, 2025

This PR changes from sending Full Name to Pretix to sending Given Name and Family Name

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pycon ❌ Failed (Inspect) Mar 11, 2025 11:22pm

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (b96ff0b) to head (74db528).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4396   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         351      351           
  Lines       10004    10008    +4     
  Branches      708      708           
=======================================
+ Hits         9459     9463    +4     
  Misses        454      454           
  Partials       91       91           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patrick91 patrick91 force-pushed the feature/separate-first-last-name-invoice branch from 0281b1f to 7fd9d44 Compare March 11, 2025 22:25
@patrick91 patrick91 force-pushed the feature/separate-first-last-name-invoice branch from 75f6e1a to 3729a2c Compare March 11, 2025 23:06
@patrick91 patrick91 changed the title Send first and last name for invoice info Send given and family name for invoice info Mar 11, 2025
@patrick91 patrick91 marked this pull request as ready for review March 11, 2025 23:19
@patrick91
Copy link
Member Author

If I understood correctly codegen fails because it's trying to use the current backend 😊

@patrick91 patrick91 requested a review from marcoacierno March 11, 2025 23:19
@patrick91 patrick91 merged commit 8c3ca32 into main Mar 11, 2025
5 of 7 checks passed
@patrick91 patrick91 deleted the feature/separate-first-last-name-invoice branch March 11, 2025 23:23
marcoacierno added a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants