Skip to content

PEP 784: Mark as Accepted #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented Apr 26, 2025

  • SC/PEP Delegate has formally accepted/rejected the PEP and posted to the Discussions-To thread
  • Pull request title in appropriate format (PEP 123: Mark as Accepted)
  • Status changed to Accepted/Rejected
  • Resolution field points directly to SC/PEP Delegate official acceptance/rejected post, including the date (e.g. `01-Jan-2000 <https://discuss.python.org/t/12345/100>`__)
  • Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments
  • Discussions-To, Post-History and Python-Version up to date

I removed any references to removal or deprecation of the existing modules other than to say that it is left to a future decision as part of the Backwards Compatibility section.

At the behest of Barry, cc'ing @python/steering-council to review the exact language.


📚 Documentation preview 📚: https://pep-previews--4387.org.readthedocs.build/

As requested by the Steering Council
@emmatyping emmatyping requested a review from gpshead as a code owner April 26, 2025 00:13
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions.

Assuming the Council is happy with the text, please also include the relevant changes to the headers in this PR, and update the title appropriately.

A

Comment on lines +257 to +258
documentation for existing modules will be updated to reference the new names
as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the new names now become canonical? The PEP should take a position.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes the new names should become canonical. Let's see what other SC members think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is for them to become canonical as that is why the compression namespaces is useful. I expect we may iterate on how exactly to present this in our docs outside the PEP.

As far as the text in the PEP goes adding something along the lines of:

"The use of the new compression names will be promoted over the original top level module names in the Python documentation when the users minimum Python version support requirements makes that feasible."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a sentence about this in 53ab0b5. Not sure if I should be stronger in my wording but hopefully that clearly makes a stance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my page was open from last night and I missed Greg's comment. I'll include that text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 9d58ebc, I made a slight edit to the sentence to clarify, hopefully that's ok!

@AA-Turner
Copy link
Member

(adding the label as this PR requires governance approval)

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the one suggestion, this LGTM, but let's give time for the other @python/steering-council members to weigh in.

emmatyping and others added 2 commits April 25, 2025 18:32
Co-authored-by: Barry Warsaw <barry@python.org>
@emmatyping emmatyping changed the title PEP 784: Remove deprecation and removal timeline PEP 784: Remove deprecation and removal timeline, mark PEP accepted Apr 26, 2025
@AA-Turner AA-Turner changed the title PEP 784: Remove deprecation and removal timeline, mark PEP accepted PEP 784: Mark as Accepted Apr 26, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants