-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom container to the realtime plugin #1869
Add a custom container to the realtime plugin #1869
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition to this plugin! I've added 3 comments, hope you have time to address them. Afterwards we can get this merged!
No idea why this was gone in this branch.
This looks good Hans, the docstring is pretty clear so I hope users can work with this.
Though that does make sense, I'm hesitant from a complexity perspective. Adding a core Folium class doesn't seem to weigh up to facilitating a single type hint for an optional argument in a single plugin. Having too many layers of class inheritance makes things more complicated to understand. So I think I'm fine with how it's solved now. I'll go ahead and merge it now. Thanks for your contribution to Folium! |
Add the container parameter from the leaflet
realtime
plugin to the Foliumrealtime
plugin. So far, only tested withMarkerCluster
. Also add tests and improved the documentation.