Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry-core 2.0.1 installs fewer files #10042

Closed
0-wiz-0 opened this issue Jan 13, 2025 · 7 comments
Closed

poetry-core 2.0.1 installs fewer files #10042

0-wiz-0 opened this issue Jan 13, 2025 · 7 comments
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Jan 13, 2025

Description

After updating poetry-core to 2.0.0 (or 2.0.1, the updates were close together, I'm not quite sure) in pkgsrc, some packages using it installed fewer files than before.
Examples:
beets 2.2.0
construct-classes 0.1.2
fritz_exporter 2.3.1
sydent 2.6.1
test-textual-snapshot 1.0.0
pypika-tortoise 0.3.2

Is this change intended by poetry-core or a bug?

If intended, can you please advise how the projects should be fixed?

Thank you.

Workarounds

Install the files manually :-)

Poetry Installation Method

system package manager (eg: dnf, apt etc.)

Operating System

NetBSD

Poetry Version

2.0.1

Poetry Configuration

n/a

Python Sysconfig

See above.

Example pyproject.toml

See above.

Poetry Runtime Logs

Command is not failing.

@0-wiz-0 0-wiz-0 added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jan 13, 2025
@dimbleby
Copy link
Contributor

Bug report unclear - I don't know what the connection between those logs and poetry is?

But yes there are breaking changes ar 2.0 re what files are included, please read the release announcement

@Secrus
Copy link
Member

Secrus commented Jan 14, 2025

poetry-core had the includes system refactored with 2.0. Could you check your package includes, as that is the most likely cause of the breakage on your end?

Since this concerns a different kind of packaging/repackaging system, I am going to close this issue. If you find that there is still some issue about what files are not found in the build artifact, please create a reproduction.

@Secrus Secrus closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 14, 2025

We're using python -m build --wheel to build wheels and then install them with installer. This hasn't changed.
The linked files show which files are not installed any longer, you can ignore the rest.
I did read the CHANGELOG and the pinned issue #9136 but didn't find the relevant item. Can you be more explicit please?

@Secrus
Copy link
Member

Secrus commented Jan 14, 2025

@0-wiz-0 unless you find some irrefutable proof that poetry-core is at fault, you should first check with the project you see changes in. The includes change I was referring to is this.

@Secrus
Copy link
Member

Secrus commented Jan 14, 2025

  1. include and packages are not the same things.
  2. These files shouldn't be included in the wheels, since on installation they would be put in the site-packages directory, where they would clash with files from other packages. If you want the previous behavior, the easiest fix would be to pin your backend to <2 version. Otherwise, you have to add { path = "<file/dir path>", format = ["sdist", "wheel"] } for each of the include entries.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 14, 2025

Thank you for the explanations.
I agree that this is a net positive change

For me it was hard to find out from the Changelog.
I suggest that in the future changes will not only be described on the source level but also on the result level.
If you don't know what includes are, changes to include handling will not let you guess that this means changes in the installed files by a binary wheel.

Thanks.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants