Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed ImageTk._show #8782

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Removed ImageTk._show #8782

merged 1 commit into from
Mar 3, 2025

Conversation

radarhere
Copy link
Member

Pillow/src/PIL/ImageTk.py

Lines 268 to 269 in d7d48df

def _show(image: Image.Image, title: str | None) -> None:
"""Helper for the Image.show method."""

This helper is actually unused, so I suggest deprecating it.

@radarhere radarhere added the Deprecation Feature that will be removed in the future label Mar 1, 2025
@hugovk
Copy link
Member

hugovk commented Mar 2, 2025

It's underscore-prefixed, so shall we just remove it?

@radarhere radarhere changed the title Deprecate ImageTk._show Removed ImageTk._show Mar 2, 2025
@radarhere radarhere removed the Deprecation Feature that will be removed in the future label Mar 2, 2025
@radarhere
Copy link
Member Author

Ok, I've updated the commit.

@hugovk hugovk merged commit 1a62ef9 into python-pillow:main Mar 3, 2025
54 of 55 checks passed
@radarhere radarhere deleted the imagetk branch March 3, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radarhere @hugovk