Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Bulma v1 #1265

Open
hedyhli opened this issue Mar 22, 2024 · 0 comments
Open

Using Bulma v1 #1265

hedyhli opened this issue Mar 22, 2024 · 0 comments
Labels
area: frontend Related to site content and user interaction status: planning Discussing details status: stalled Something is blocking further progress

Comments

@hedyhli
Copy link
Member

hedyhli commented Mar 22, 2024

Bulma v1.0.0 is here! 🎉
https://bulma.io/documentation/start/migrating-to-v1/

A number of useful features were introduced that benefit us directly.

This means most, if not all...

...are no longer necessary once we upgrade.

Note though, we're still blocked by lemonsaurus/django-simple-bulma#100 if we decide to do this.

Overview of the changes

For now, I can think of:

  • Adapting to whatever changes django-simple-bulma introduces in response to this.
  • Remove the dark variables in settings.py and make use of Bulma's built-in dark theme support with minimal customizations.
  • Remove rules that use [data-theme="dark"] throughout the site for ones that are covered by Bulma.
  • Use CSS Variables in place of hardcoded Bulma colors throughout the site.

Why?

The benefits of this are alike that of modularization and that of the best practices reviewers for our (other) Python projects tend to push for. The frontend becomes much, much easier to maintain and update in the long run and we'll now be relying less on "hacky" solutions to make something which Bulma previously did not support, work. Of course, the code also becomes much more readable.


Currently, there's not much we can do than wait, but I've opened this issue to start the conversation and receive some input regarding the possible migration to v1 after it's supported by django-simple-bulma.

@hedyhli hedyhli added area: frontend Related to site content and user interaction status: planning Discussing details status: stalled Something is blocking further progress type: enhancement Changes or improvements to existing features labels Mar 22, 2024
@jchristgit jchristgit removed the type: enhancement Changes or improvements to existing features label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to site content and user interaction status: planning Discussing details status: stalled Something is blocking further progress
Projects
None yet
Development

No branches or pull requests

2 participants