bugfix: utils: catch configparser.Error #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches any configparser exceptions when parsing the user's pypirc file. Without this the user would see an uncontrolled exception trace, which in turn could sometimes leak sensitive configuration fields. The "fix" here is to mask the configparser exception entirely with twine's own `InvalidConfiguration` exception. This avoids the leakage risk, but it also means that the errors we return to users are slightly less specific in terms of where their invalid syntax is. We offset that by including a link to the pypirc docs. Fixes #1233. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
1 task
|
LGTM, thanks! |
sigmavirus24
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches any configparser exceptions when parsing the user's pypirc file. Without this the user would see an uncontrolled exception trace, which in turn could sometimes leak sensitive configuration fields.
The "fix" here is to mask the configparser exception entirely with twine's own
InvalidConfigurationexception. This avoids the leakage risk, but it also means that the errors we return to users are slightly less specific in terms of where their invalid syntax is. We offset that by including a link to the pypirc docs.Fixes #1233.