Prevent empty redaction rectangles #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure non-empty redaction rectangles. OverlayText must either be omitted entirely or non-white, in which case a sensible redaction rectangle width is also ensured. A minor correction to method "remove_rotation" ignores invalid hyperlinks during annotation / hyperlink rectangle restoration.
julian-smith-artifex-com
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
White-space OverlayText is treated as if entirely omitted.
If the redaction rectangle width is too small to reasonably show text, insertion attempts for replacing text are silently ignored.
A minor correction to method "remove_rotation" ignores invalid hyperlinks during annotation / hyperlink rectangle restoration.