Immunize against empty table headers #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved check for empty tables, fixes bugs when determining table headers. Improved computation of enveloping vector graphic rectangles. Ignore more meaningless "pseudo" tables
julian-smith-artifex-com
approved these changes
Feb 29, 2024
Comment on lines
95
to
+97
| EDGES = [] # vector graphics from PyMuPDF | ||
| CHARS = [] # text characters from PyMuPDF | ||
| TEXTPAGE = None |
There was a problem hiding this comment.
Would like to eventually remove the use of these globals, but ok for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved check for empty tables, fixes bugs when determining table headers.
More complete and faster computation of enveloping vector graphic rectangles.