fix: retain WellPlatePlan type when used for MDASequence.stage_positions #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `_validate_stage_positions` method in the `MDASequence` class to improve the validation process for the `stage_positions` field. The method now checks if the value is an instance of `np.ndarray` and handles it accordingly. Additionally, it adds support for validating a `WellPlatePlan` object as the `stage_positions` value. The commit also includes a new test case in `test_well_plate.py` to ensure that the `stage_positions` field in `MDASequence` correctly handles a `WellPlatePlan` object. Fixes #XYZ
tlambert03
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 93.67% 93.77% +0.10%
==========================================
Files 18 18
Lines 1233 1237 +4
==========================================
+ Hits 1155 1160 +5
+ Misses 78 77 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure that passing a WellPlatePlan to MDASequence.stage_positions retains the proper type. Useful for pymmcore-plus/pymmcore-widgets#362