Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bad bpms reasons #472

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Add bad bpms reasons #472

merged 5 commits into from
Nov 22, 2024

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Nov 21, 2024

Looks now like

   INFO | Bad BPMs Summary. Hint: '[BPM]' were filtered as known bad BPMs. | scripts.bad_bpms_summary
   INFO | Highest bad BPMs of LHCB1 from HARPY:
                 BPM          X                   Y           Reasons
         BPM.11R4.B1  100.0% (18/18)      100.0% (18/18)      EXACT_ZERO | FLAT
         BPM.29L6.B1  100.0% (18/18)              -           EXACT_ZERO
          BPM.8L1.B1  100.0% (18/18)              -           EXACT_ZERO | FLAT
        BPMSX.4L8.B1  100.0% (18/18)              -           SPIKY
        BPMSE.4L6.B1  100.0% (18/18)              -           SPIKY
        BPMSX.7R1.B1  100.0% (18/18)      100.0% (18/18)      EXACT_ZERO | FLAT
         BPM.18R2.B1          -            55.6% (10/18)      EXACT_ZERO | scripts.bad_bpms_summary

@JoschD JoschD added Type: Feature A (suggetion for a) new feature or enhancement in functionality. Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Low Work on this if you have some spare time. Type: Documentation Improvements, updates and fixes to the documentation. Type: Release Issue preparing for a release. labels Nov 21, 2024
@JoschD JoschD self-assigned this Nov 21, 2024
@JoschD JoschD marked this pull request as ready for review November 22, 2024 10:21
@JoschD JoschD requested a review from a team as a code owner November 22, 2024 10:21
@JoschD JoschD requested review from fsoubelet and jgray-19 November 22, 2024 10:26
fsoubelet
fsoubelet previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me, not spooked by the brew step failing in CI as long as coverage workflow is fine.

jgray-19
jgray-19 previously approved these changes Nov 22, 2024
View reviewed changes
omc3/scripts/bad_bpms_summary.py Outdated Show resolved Hide resolved
@JoschD JoschD dismissed stale reviews from jgray-19 and fsoubelet via 4463bf9 November 22, 2024 14:21
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 22, 2024

Code Climate has analyzed commit 4463bf9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 91.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.0% (0.0% change).

View more on Code Climate.

@JoschD JoschD merged commit f57314a into master Nov 22, 2024
6 of 22 checks passed
@JoschD JoschD deleted the bad_bpms_reasons branch November 22, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsoubelet fsoubelet fsoubelet left review comments

@jgray-19 jgray-19 jgray-19 left review comments

Assignees

@JoschD JoschD

Labels
Estimate: Easy Good first issue for newcomers. Straightforward fixes. Priority: Low Work on this if you have some spare time. Type: Documentation Improvements, updates and fixes to the documentation. Type: Feature A (suggetion for a) new feature or enhancement in functionality. Type: Release Issue preparing for a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoschD @fsoubelet @jgray-19