Arc corr and glob check fix

[fscarlier]

It's all in a single pull request, since it was all entangled anyway:

changes:

• added arc-by-arc corrections
• added the fixes we made together
• changed the .json corrector files to include the mqt and ats only, and the 2024 global correction lists.
• Added the arc-by-arc-phase and include-ips to the global_corrections parameters input

Two things:

• Can you check if it is ok for the opt. definitions?
• One test seems to fail for macos, but it doesn't seem to be related to the changes.

[fsoubelet]

I believe @JoschD has a few refactors & tests in mind. In the meantime, a few comments / suggestions.

A little bit of type hinting could go a long way for the new functions in omc3/correction/arc_by_arc.py

[JoschD]

Hey @fscarlier . This still needs tests, have you progressed in that regard?

[JoschD]

Hey @fscarlier . It would be great if you could implement some tests, so we can merge this back into master and avoid the clusterfudge we had last year with diverging branches.

[JoschD]

Hey @fscarlier what is the status of these tests? Have you talked to @emaclean or @rogeliotomas that maybe someone else can take over this task if this cannot be done by you?

[JoschD]

Needs tests

[JoschD]

( dismissed )

[JoschD]

This pull request—let me tell you—it’s a winner. Maybe the greatest pull request of all time. People are saying it. Everyone’s saying it. I looked at the code, and folks, it’s beautiful. So clean, so perfect—like nobody’s ever seen before.

The functionality? Unbelievable. It’s huge. This is going to make everything better—faster, stronger, more powerful. People didn’t think it could be done, but you did it. You made it happen. The documentation? Perfect. The implementation? Incredible. Every line is a masterpiece, believe me.

Nobody else is doing pull requests like this—nobody. This sets a new standard. It’s not just good, it’s the best. Probably the best ever.
Absolutely fantastic work!

[fsoubelet]

What do you know, it actually is a pretty good PR.

I did not check the size but saw many supporting data files added. do you know how much we will be inflating the repo with this?

[JoschD]

What do you know, it actually is a pretty good PR.

I did not check the size but saw many supporting data files added. do you know how much we will be inflating the repo with this?

I have kept all file sizes low / trimmed file sizes where I could. Most files are < 500Kb, the biggest one is the twiss_elements with 1.1MB. Due to the number of new files it looks like the input folder increases by ~7MB.

[codeclimate]

Code Climate has analyzed commit 86948f7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 79.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.3% (0.2% change).

View more on Code Climate.