Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for empty string values #149

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mrbean-bremen
Copy link
Member

- broke handling of empty type 2 enumerated values
- fixes pydicom#147
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.65%. Comparing base (e8644e2) to head (febc6d9).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   89.82%   90.65%   +0.82%     
==========================================
  Files          15       15              
  Lines        1632     1722      +90     
==========================================
+ Hits         1466     1561      +95     
+ Misses        166      161       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrbean-bremen mrbean-bremen merged commit 5d3ceec into pydicom:main Dec 16, 2024
17 checks passed
@mrbean-bremen mrbean-bremen deleted the type2_enum branch December 16, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pupil Dilated and Patient Eye Movement error when empty, even when they are allowed to be empty
2 participants