-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of "may be present" condition may be incorrect #29
Comments
mrbean-bremen
added a commit
to mrbean-bremen/dicom-validator
that referenced
this issue
Aug 8, 2023
- fixes pydicom#29 - the test was already present, but had a wrong expectation
mrbean-bremen
added a commit
that referenced
this issue
Aug 8, 2023
- fixes #29 - the test was already present, but had a wrong expectation
Still not correct - the test checks the wrong value... |
mrbean-bremen
added a commit
to mrbean-bremen/dicom-validator
that referenced
this issue
Aug 11, 2023
- fixes pydicom#29 - add option --recreate-json for testing purposes
mrbean-bremen
added a commit
that referenced
this issue
Aug 12, 2023
- fixes #29 - add option --recreate-json for testing purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the condition for a tag after "may be present" cannot be parsed, it should be handled as if it can always be present (same as "may be present otherwise"). Currently it is handled as "is not allowed", which is wrong (false positive).
This is also true for complex conditions, where only a part of the condition could be evaluated.
Seen in "General Series" module for Patient Position which has the condition:
The text was updated successfully, but these errors were encountered: