Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue with plugins on windows platform #314

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SegaMegaDrive16
Copy link

Plugins could`t be registered by register_plugins_path method

@mottosso
Copy link
Member

mottosso commented Jun 9, 2017

Thanks @GreenGoseWithFunnyHat, are you able to provide an example I could use to reproduce this problem? I'll use that to create a test for it, so the problem is automatically caught the next time it appears.

@SegaMegaDrive16
Copy link
Author

SegaMegaDrive16 commented Jun 9, 2017

I guess that windows plaform (tested on widnows 7 with different file editors) creates \r\n instead of \n on linux at the end of each string. ( I have found discussion about this, they say that MS-DOS chose CR+LF, and Windows inherited this.
To catch this problem you need to test this on windows 7 platfrom ( i guess in 10th version it was fixed ) or replace '\n' to '\r\n' in you plugins file.
If you need i can attach file with \r\n at the end of strings.

@mottosso
Copy link
Member

mottosso commented Jun 9, 2017

Would it be possible to create a small sample, and upload it here? That way I can include this in the automated test suite.

@mottosso
Copy link
Member

mottosso commented Jun 9, 2017

If you need i can attach file with \r\n at the end of strings.

Yes, please. :)

@BigRoy
Copy link
Member

BigRoy commented Feb 20, 2018

@GreenGoseWithFunnyHat have you been able to find some time to set up a reproducable example and maybe also implement a test that ensures it's safe with these commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants