Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkgconf-pypi entrypoint #5552

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

virtuald
Copy link
Contributor

@virtuald virtuald commented Mar 6, 2025

  • This allows pkgconf --cflags pybind11 and similar commands to work as expected if pkgconf is installed from pypi

Description

pkgconf is used by build tools such as meson to find pkg-config files. In a virtualenv, the system pkgconf cannot find pybind11 installed in the virtualenv (though meson has other ways to do this).

https://github.com/pypackaging-native/pkgconf-pypi packages pkgconf into a wheel, and uses entrypoints to extend the PKG_CONFIG_PATH so that .pc files can be found in the virtualenv (docs).

pybind11 already distributes a .pc file in the wheel. This PR adds an entrypoint so that it's usable with pkgconf-pypi.

Suggested changelog entry:

Added support for finding pybind11 using pkgconf distributed on pypi

@virtuald virtuald requested a review from henryiii as a code owner March 6, 2025 05:48
- This allows `pkgconf --cflags pybind11` and similar commands to work as expected
  if pkgconf is installed from pypi
@henryiii henryiii merged commit ded70fe into pybind:master Mar 6, 2025
80 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 6, 2025
@virtuald virtuald deleted the pkgconf-pypi branch March 7, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Possibly needs a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants