Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed README.md #5049

Closed

Conversation

sasidhara-kashyap0903
Copy link

Description

Suggested changelog entry:

@rwgk
Copy link
Collaborator

rwgk commented Mar 5, 2024

Sorry I don't think this README is the right place to add an example, especially not one this complex and rather arbitrary (and untested).

For the code: I'm guessing people look in the tests, which are basically certain to be correct. At least that's where I usually look to get a start.

For the build commands: that's only for one platform. I recommend looking at the GitHub Actions cmake logs to see what the commands are for any supported platform.

@sasidhara-kashyap0903
Copy link
Author

sir, I want to contribute to this README.md file, what changes can I make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants