Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

pybind / pybind11 Public

Notifications You must be signed in to change notification settings
Fork 2.1k
Star 16.3k

Code
Issues 555
Pull requests 131
Discussions
Actions
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Wiki
Security
Insights

smart_holder trampoline shared_from_this support#3023

Merged

rwgk merged 67 commits intopybind:smart_holderpybind/pybind11:smart_holderfrom rwgk:sh_shared_from_thisrwgk/pybind11:sh_shared_from_thisCopy head branch name to clipboard

Jun 30, 2021

+528-48

Conversation Commits67 (67)Checks Files changed

Commits

Commits on Jun 29, 2021

Isolating shared_from_this tests from test_smart_ptr (minimal changes).
rwgk
committed
Experiments: 1. disabling enable_shared_from_this, 2. using smart_holder in test_class_sh_shared_from_this.cpp
rwgk
committed
Breaking up test_shared_ptr_from_this_and_references into smaller subtests. Skipping the only test that generates an ASAN heap-use-after-free.
rwgk
committed
Restoring init_holder overload for std::enable_shared_from_this and original tests/test_smart_ptr.py.
rwgk
committed
static_assert in from_raw_ptr_take_ownership, to be tested.
rwgk
committed
enable_shared_from_this_from_raw_ptr_take_ownership_guard: better static_assert that also triggers for derived classes.
rwgk
committed
Adding from_raw_pointer_take_ownership_or_shared_from_this().
rwgk
committed
Adding test_class_sh_shared_from_this.cpp to tests/CMakeLists.txt.
rwgk
committed
Fully emulating type_caster_base-related behavior: trying shared_from_this also for unowned pointees.
rwgk
committed
Experiment: commenting out test_class_sh_shared_from_this.
rwgk
committed
Experiment: effectively undoing all shared_from_this modifications.
rwgk
committed
Experiment: undoing even more.
rwgk
committed
Experiment: restoring original smart_holder_type_casters.h from smart_holder branch.
rwgk
committed
Revert "Experiment: restoring original smart_holder_type_casters.h from smart_holder branch."
rwgk
committed
Revert "Experiment: undoing even more."
rwgk
committed
Revert "Experiment: effectively undoing all shared_from_this modifications."
rwgk
committed
Revert "Experiment: commenting out test_class_sh_shared_from_this."
rwgk
committed
Copying in shared_from_this_custom_deleters.cpp from github.com/rwgk, with adjustments.
rwgk
committed
Explictly discarding [[nodiscard]] to avoid MSVC CI failures.
rwgk
committed
Inserting #ifdef to preempt Windows fatal exception.
rwgk
committed
Adding shared_ptr_reset_and_rescue_pointee_model_proof_of_concept.
rwgk
committed
MSVC 2015 compatibility.
rwgk
committed
WIP snapshot.
rwgk
committed
WIP snapshot: std::get_deleter experiment.
rwgk
committed
WIP snapshot: replacing std::shared_ptr<bool> flag_ptr with simple bool armed_flag.
rwgk
committed
Fixing oversight (clang-tidy error).
rwgk
committed
Inserting const_cast for std::get_deleter return, to keep Ubuntu 20 GCC 6.3.0 happy.
rwgk
committed
Adding back explicit but default copy constructor, to keep some older compilers happy.
rwgk
committed
Replacing virtual guarded_operator_call with non-virtual guarded_delete.
rwgk
committed
Fixing silly oversight (discovered while creating PR pybind#3041 ).
rwgk
committed
Fixing git rebase -X theirs accident.
rwgk
committed
First attempt to make shared_from_this and trampolines play nicely. Passes all pybind11 and PyCLIF unit tests ASAN clean, but not the open_spiel iterated_prisoners_dilemma_test.
rwgk
committed
First fully successful attempt to make shared_from_this and trampolines play nicely.
rwgk
committed
Disabling debugging call of weak_from_this for C++ < 17.
rwgk
committed
Trying again, to get around unused parameter warnings-as-erros.
rwgk
committed
Two minor platform-specific fixes. Using static_cast instead of reinterpret_cast.
rwgk
committed
nodiscard fix.
rwgk
committed
Adding tests involving stashing shared_ptrs. WIP.
rwgk
committed
Resolving gcc warning-as-error (many versions, old and new).
rwgk
committed
Attempts to side-step various platform-specific issues.
rwgk
committed
Adding test_pass_released_shared_ptr_as_unique_ptr, exercising new guard in smart_holder_type_casters.h.
rwgk
committed
Minor clang-tidy fix.
rwgk
committed
Leveraging new noop_deleter_acting_as_weak_ptr_owner to retrieve released vptr.
rwgk
committed
Partial cleanup of tests. WIP. The cleanup uncovered a major problem.
rwgk
committed
Applying clang-tidy suggested fixes.
rwgk
committed
smart_holder_poc.h: type-erase raw_ptr before passing to shared_ptr::reset, to not trigger populating the shared_from_this weak_ptr. This way the only way the weak_ptr is populated is through loade…
rwgk
committed
Simpler and safe implementation based on new requirement: C++ (outside of the Python object) needs to hold a shared_ptr before shared_from_this is called. This is more similar to the existing imple…
rwgk
committed
Automatic clang-tidy fixes.
rwgk
committed
Adding // NOLINT for clang-tidy.
rwgk
committed
Adding test_pure_cpp_sft_raw_ptr (with 3 TODO: Fix), test_pure_cpp_sft_shd_ptr (works as desired).
rwgk
committed
Preparation for being smarter about casting to void * to evade to shared_from_this mechanism.
rwgk
committed
Use casting to void * to evade to shared_from_this mechanism only if pointee_depends_on_holder_owner, but currently only for from_raw_ptr_take_ownership.
rwgk
committed
Resolving TODOs for from_unique_ptr void_cast_raw_ptr. Adding test to exercise the path through cast. The path through init.h is missing a test that would fail if the flag is incorrect. The p…
rwgk
committed
Removing experimental code from here. Will be moved to https://github.com/rwgk/rwgk_tbx .
rwgk
committed
Cleaning out debug code.
rwgk
committed
Updating Catch version to latest, in hopes of resolving the GHA download issue affecting all MSVC builds.
rwgk
committed
Revert "Updating Catch version to latest, in hopes of resolving the GHA download issue affecting all MSVC builds."
rwgk
committed
Adding a few comments after review by @laramiel .
rwgk
committed
A couple more enhancements based on feedback by @laramiel .
rwgk
committed
This change fixes the 6 unit tests in
rwgk
committed
Adding unit test: test_multiple_registered_instances_for_same_pointee
rwgk
committed
Adding unit tests: 2 x test_std_make_shared_factory
rwgk
committed
Fixing git rebase -X theirs smart_holder issue.
rwgk
committed
Adding test_multiple_registered_instances_for_same_pointee_leak. Subtle changes in smart_holder_type_caster_load, trying to work on weak_ptr for shared_ptr_trampoline_self_life_support, but that di…
rwgk
committed
Adding test_multiple_registered_instances_for_same_pointee_recursive.
rwgk
committed
Converting C assert to pybind11_fail (to play safe).
rwgk
committed
Small reduction in code complexity.
rwgk
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.