Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The main repository and submodule both have source code dependencies on the usage of pybind11 #5521

Open
2 of 3 tasks
HRXWEB opened this issue Feb 14, 2025 · 1 comment
Labels
triage New bug, unverified

Comments

@HRXWEB
Copy link

HRXWEB commented Feb 14, 2025

Required prerequisites

What version (or hash if on master) of pybind11 are you using?

stable branches

Problem description

Reproduce by files uploading

Problem

When the main repo and the submodule repo also depends the pybind11 in source code way, the command pybind11_add_module in cmakelists.txt of main repo will

  • use the function defined in test_pybind11/third-party/sub/third-party/pybind11/tools/pybind11Tools.cmake
  • not the expected definition in test_pybind11/third-party/pybind11/tools/pybind11Tools.cmake

How to proof this problem is exist?

I have deleted this two files the pybind11 in test_pybind11/third-party/pybind11:

deleted:    tools/pybind11NewTools.cmake
deleted:    tools/pybind11Tools.cmake

But I still can build the repo successfully by

mkdir build
cd build
cmake ..
make

Reproducible example code

code is here: https://github.com/HRXWEB/test_pybind11

Is this a regression? Put the last known working version here if it is.

Not a regression

@HRXWEB HRXWEB added the triage New bug, unverified label Feb 14, 2025
@HRXWEB
Copy link
Author

HRXWEB commented Feb 14, 2025

Whoa! upload files is failed, please download the Reproducible example code in https://github.com/HRXWEB/test_pybind11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New bug, unverified
Projects
None yet
Development

No branches or pull requests

1 participant