Move final assignment later

pybind · Nov 8, 2024 · a3ff673 · a3ff673
1 parent 7fcf820
commit a3ff673
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/include/pybind11/detail/class.h b/include/pybind11/detail/class.h
@@ -603,7 +603,6 @@ extern "C" inline int pybind11_getbuffer(PyObject *obj, Py_buffer *view, int fla
 
     // Fill in all the information, and then downgrade as requested by the caller, or raise an
     // error if that's not possible.
-    view->obj = obj;
     view->buf = info->ptr;
     view->itemsize = info->itemsize;
     view->len = view->itemsize;
@@ -659,7 +658,10 @@ extern "C" inline int pybind11_getbuffer(PyObject *obj, Py_buffer *view, int fla
         }
     }
 
+    // Set these after all checks so they don't leak out into the caller, and can be automatically
+    // cleaned up on error.
     view->internal = info.release();
+    view->obj = obj;
     Py_INCREF(view->obj);
     return 0;
 }